Arbites->Razor-Jaw Augment talent doesn't credit kill to player if bleeds get the kill

Issue Type (Required):

Talents

Issue Description (Required):

Arbites->Razor-Jaw Augment talent doesn’t credit kill to player if bleeds get the kill.
It will not trigger any on-kill talents or appear in the combat feed.

Steps to Reproduce (Required):

Order Hedge to attack a minion, observe dog bleed kills not counting on elites to trigger other talents and buffs.

[PC] Do You Use Mods? (Optional):

Yes, but I haven’t tried disabling them, mods let me spot the issue in the first place.

nil attacking_player if dog bleeds.

_process_attack_result  nil     buff    damaged bleeding        131.25
_process_attack_result  nil     buff    damaged bleeding        131.25
_process_attack_result  nil     buff    died    bleeding        131.25

There are cases where the dog+bleeds pounce appears to count as a player kill but that’s because the dog bleed tick (ha, dog tick, get it?) wasn’t the killing blow; false positive.
P.S.
Fix: guessing it’s missing the last 2 params to assign ownership of the bleed debuff (buff) like most of the other applications, e.g. ogryn bleeds.

, "owner_unit", template_context.unit

in the call:

buff_extension:add_internally_controlled_buff_with_stacks("bleed", stacks, t)

P.P.S. Maybe add the owner unit to brittles too (rending_debuff), it could be an interesting thing to track.
P.P.P.S. Can we get rid of <* loadout> logged debug dumps or are they still needed for tracking down issues?

10 Likes

Hedge

captain-america-i-understood-that-reference

:skull:

2 Likes